-
Notifications
You must be signed in to change notification settings - Fork 813
feat: Add experimental support for FreeBSD(R) OS #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ce791d0 to
cd92dff
Compare
|
@Martinfx please use commitizen commit message
See https://artificial-intelligence.sites.arm.com/computelibrary/latest/contribution_guidelines.xhtml How to check the rules We check the rules using pre-commit (https://pre-commit.com/) framework. pre-commit can be installed via pip. After installing, run the following command in the root directory of the repository: pre-commit install This will create the hooks that perform the required formatting checks and will automatically run just before committing to flag issues. Following conventional commits https://www.conventionalcommits.org/en/v1.0.0/#specification each commit must have a type from the following: build, ci, docs, feat, fix, perf, refactor, style, test, chore, revert, bump. In this format: [optional scope]: . Commitizen (https://commitizen-tools.github.io/commitizen/) is used to do check that this standard is followed and is used in the pre-commit framework: pre-commit install –hook-type pre-push This will create the pre-push hook that is going to check the commit message format before pushing to remote. |
gunes-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Martinfx, thank you for your contribution.
In README, can u add FreeBSD, probably with the (R) symbol as in others, under Supported Systems subsection as experimental?
Also, can u call it out under "Trademarks and Copyrights" subsection? Looks like their guidance in https://www.freebsd.org/copyright/trademarks/ says:
FreeBSD is a registered trademark of The FreeBSD Foundation.
261c366 to
6ce91ba
Compare
Hi, I added all to README |
|
Hi @Martinfx , sorry for the radio silence on this one. I made a comment which is the reason of the CI failure. You should also squash the commits into one as ComputeLibrary_squash_check job says above. Also, can you rename your commit title and PR title as: feat: Add experimental support for FreeBSD(R) OS |
6ce91ba to
cad9c55
Compare
Hi, |
I think you need to run the pre-commit hooks to see this clang-format issue. Please have a look at @morgolock's message above. |
Hi,
This PR implements support for the FreeBSD os. I tested on aarch64 and amd64.