Skip to content

Conversation

@Stephen0512
Copy link
Contributor

This pull request fixes a file-handling issue in the tests. The current implementation uses open() without explicitly closing the file for EXPECT_DATA, which can potentially lead to resource leaks. While Python's garbage collector will eventually close the file once it is no longer referenced, it is generally better practice to explicitly close files or use a context manager.

This change replaces the direct open() call with a with statement to ensure proper file closure and follow Python best practices. The issue was identified during an ongoing research project.

@wyapx
Copy link
Collaborator

wyapx commented Jan 27, 2026

Although it only runs on pytest to identify potential unexpected error, but that is a good point.

A good patch, thanks

@wyapx wyapx merged commit fab0f64 into DCZYewen:master Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants