Skip to content

Conversation

@mpreyskurantov
Copy link
Contributor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades jQuery from version 3.7.1 to 4.0.0, a major version update that was released in February 2024. The codebase already contains test comments anticipating jQuery 4+ behavior changes, indicating this upgrade was planned.

Changes:

  • Updates jQuery version in the pnpm workspace catalog from 3.7.1 to 4.0.0
  • Updates all dependency references in pnpm-lock.yaml with new version and integrity hash
  • Simplifies the jQuery vendor path from explicit file reference to package name resolution

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-workspace.yaml Updates jQuery catalog entry from 3.7.1 to 4.0.0
pnpm-lock.yaml Updates all jQuery dependency references and integrity hashes across packages to reflect 4.0.0
packages/devextreme/build/gulp/vendor.js Changes jQuery vendor path from 'jquery/dist/jquery.js' to 'jquery' to leverage package.json exports in jQuery 4.0
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

},
{
path: 'jquery/dist/jquery.js'
path: 'jquery'
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'jquery/dist/jquery.js' to 'jquery' relies on Node.js module resolution to find the correct entry point. While this follows the pattern used by 'jspdf-autotable', ensure that:

  1. require.resolve('jquery') resolves to an unminified .js file in jQuery 4.0.0
  2. The automatic minified file lookup (line 89) correctly finds the corresponding .min.js file
  3. Both the regular and minified jQuery files are properly copied to the artifacts directory

Consider adding a comment explaining why the package name alone is used instead of the explicit dist path, to help future maintainers understand this intentional change from the explicit 'jquery/dist/jquery.js' path used in jQuery 3.x.

Copilot uses AI. Check for mistakes.
@mpreyskurantov mpreyskurantov requested a review from a team January 19, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants