feat: update RampsController with selectedProvider and selectedToken #7734
+1,545
−418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://d.iamgay.cn/https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
georgeweiler
commented
Jan 27, 2026
georgeweiler
commented
Jan 27, 2026
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
georgeweiler
changed the title
amitabh94
reviewed
Jan 28, 2026
amitabh94
reviewed
Jan 28, 2026
amitabh94
reviewed
Jan 28, 2026
amitabh94
reviewed
Jan 28, 2026
amitabh94
reviewed
Jan 28, 2026
| state.selectedToken = token; | ||
| }); | ||
|
|
||
| this.triggerGetPaymentMethods(regionCode, { |
Contributor
There was a problem hiding this comment.
Do you think we can use the following instead of writing wrapper functions to trigger it ?
Suggested change
| this.triggerGetPaymentMethods(regionCode, { | |
| this.getPaymentMethods(regionCode, { | |
| provider: provider.id, | |
| }).catch(() => { | |
| // ignore errors | |
| }); |
Contributor
Author
There was a problem hiding this comment.
Good idea. I will follow up with a refactor for all of the trigger methods.
AxelGes
reviewed
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR refactors the RampsController to improve naming consistency and add token selection support.
Breaking Changes
preferredProvidertoselectedProvider: Aligns naming with the newselectedTokenstate for consistency across selected entitiesgetPaymentMethodssignature: Changed fromgetPaymentMethods(options)togetPaymentMethods(region, options)to match the pattern used bygetTokensandgetProvidersNew Features
selectedTokenstate: Stores the user's selected token withsetSelectedToken()method. When a token is selected, payment methods are automatically fetched for that tokenRampsEnvironment.Local: New environment option for RampsService that points tolocalhost:3000for local developmentReferences
Mobile PR that adopts breaking changes: MetaMask/metamask-mobile#25296
Jira Ticket: https://consensyssoftware.atlassian.net/browse/TRAM-3232
Checklist
Note
Medium Risk
Medium risk due to breaking API changes (
preferredProvider→selectedProvider,getPaymentMethodssignature change) and new selection-driven side effects that auto-fetch/reset payment methods, which could affect client integrations and UI state transitions.Overview
Adds
selectedProviderandselectedTokentoRampsControllerwith newsetSelectedProvider(id)/setSelectedToken(assetId)APIs; changing either now clears payment methods/selection and triggers a freshgetPaymentMethodsfetch.Introduces breaking changes: renames
preferredProvider→selectedProvider(and setter), changesgetPaymentMethods/triggerGetPaymentMethodstogetPaymentMethods(region, options), and updatessetSelectedPaymentMethodto accept a payment-method ID (with validation).Updates payment-methods behavior to default
assetId/providerfrom controller state, auto-select the first returned payment method when the previous selection is invalid, and guard against stale updates when token/provider changes mid-request.Enhances
RampsServicewithRampsEnvironment.Local, optionalbaseUrlOverride, provider support metadata fields, and switches payment-methods API calls toGET /v2/regions/{region}/paymentsusingcryptoquery param (plus test updates).Written by Cursor Bugbot for commit 904405b. This will update automatically on new commits. Configure here.