feat(analytics): preserve transaction_type #7745
Closed
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarquevaux
force-pushed
the
feat/preserve-tx-type
branch
from
ed58250 to
2c77af1
Compare
rarquevaux
changed the title
rarquevaux
force-pushed
the
feat/preserve-tx-type
branch
from
2c77af1 to
c7fb89d
Compare
rarquevaux
force-pushed
the
feat/preserve-tx-type
branch
from
c7fb89d to
f7477b5
Compare
rarquevaux
commented
Jan 27, 2026
| index === 0 | ||
| ? TransactionType.tokenMethodApprove | ||
| : TransactionType.relayDeposit, | ||
| ? (parentTransactionMeta.type ?? TransactionType.tokenMethodApprove) |
Contributor
Author
There was a problem hiding this comment.
NB: using tx_type we loose the information about approval and relay from mm pay.
Contributor
Author
There was a problem hiding this comment.
TODO: Need to check if this type impacts the activity list.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist