Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 28, 2026

Explanation

If a keyring using a specific SRP gets cleared and re-created (during restore flow), there's a brief time window where the keyring is effectively destroyed and re-recreated, though, the AccountsController will not see this state update and won't mirror back this change for InternalAccounts.

This could lead to inconsistencies if the keyring is cleared but cannot be re-created for some reason.

Also, this prevents the AccountsController to automatically re-wrap EVM accounts (which are still not using the KeyringAccount object shape) properly and might be using an old account representation (we use this mechanism to sometimes migrate account objects automatically, and that would by-pass this migration in some very edge-cases).

References

TODO

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants