Transaction update overload #7784
Draft
+135
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lback
Add a new public updateTransaction overload that accepts an object with
transactionId and callback properties, allowing transactions to be
updated using a callback function.
Changes:
- Add UpdateTransactionRequest type for the new overload parameters
- Add updateTransaction overload that takes { transactionId, callback }
- Mark the original updateTransaction(transactionMeta, note) as deprecated
- Add new TransactionController:updateTransactionObj messenger action
- Add TransactionControllerUpdateTransactionObjAction type
- Add tests for the new updateTransactionObj messenger action
- Export new types from index.ts
Co-authored-by: matthew.walsh <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: matthew.walsh <[email protected]>
- Fix Prettier formatting for handler type definition - Add explicit return undefined for consistent-return rule Co-authored-by: matthew.walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The existing
TransactionController:updateTransactionmethod and its messenger action require passing a fullTransactionMetaobject, which can be inefficient for partial updates and does not return the updated transaction.This PR introduces a new public
updateTransactionoverload that accepts an object{ transactionId, callback }. This allows for more granular and atomic updates to a transaction's properties via a callback function, and the method now returns the updatedReadonly<TransactionMeta>.A new messenger action,
TransactionController:updateTransactionObj, has been added to expose this new, more flexible update mechanism. The originalupdateTransaction(transactionMeta, note)signature and its associated messenger action type (TransactionControllerUpdateTransactionAction) have been deprecated to encourage migration to the new approach.References
Checklist