Skip to content

Conversation

@eddelbuettel
Copy link
Member

This is a follow-up to #1447 and #1448; it addresses the root cause that the fractional second part should be int as we actually cast explicitly as int and assign NA_INTEGER. The printf format changed in #1448 is reverted back for int too.

The compiler was generally kind to us in the past here and did The Right Thing (TM). The variable is also not used outside the file (unless via an accessor that returns int).

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit 9e2f7cc into master Jan 21, 2026
26 checks passed
@eddelbuettel eddelbuettel deleted the bugfix/m_us_type branch January 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants