Update three more uses of attribute getting for R 4.6.0 or later #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1432
Just before we came out with Rcpp 1.1.1 in January (entirely on schedule), R Core / Luke / CRAN rushed out another interim fix (we were not involved) building on the preceding one from December (which was needed as they had borked builds on R-devel). This interim version switched to three more 'then new' accessors around attributes, and did so in a non-versioned way (hence breaking builds on R-release or older).
Anyway, the three small changes are fine for R-devel so this PR brings them over, but this time properly conditioned. Builds and checks on r-devel, and remains unchanged for all other versions so no hickups expected.
Checklist
R CMD checkstill passes all tests