Additional isolated declarations build fixes #32316
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted declarations This commit adds explicit return types to schematic factory functions in the test suite to satisfy the `isolatedDeclarations` requirement.
This commit adds explicit return types and parameter types to the `@angular/ssr` package to satisfy the `isolatedDeclarations` compiler option.
clydin
added
the
action: review
hybrist
approved these changes
Jan 18, 2026
| * An set of HTTP status codes that are considered valid for redirect responses. | ||
| */ | ||
| export const VALID_REDIRECT_RESPONSE_CODES = new Set([301, 302, 303, 307, 308]); | ||
| export const VALID_REDIRECT_RESPONSE_CODES: Set<number> = new Set([301, 302, 303, 307, 308]); |
Contributor
There was a problem hiding this comment.
Curious: does new Set on the RHS work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.