Skip to content

build: dedupe targets in api golden script #32669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 1 commit into from
Jan 20, 2026
Merged

build: dedupe targets in api golden script #32669

crisbeto merged 1 commit into from
Jan 20, 2026
+5 −2

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 18, 2026

In the past we had one API golden target per component, but now the target is per package. This means that if we run something like approve-goldens material/button material/dialog material/datepicker, we'll run the same command three times.

These changes dedupe the set of targets.

@crisbeto
build: dedupe targets in api golden script
393a3c9 
In the past we had one API golden target per component, but now the target is per package. This means that if we run something like `approve-goldens material/button material/dialog material/datepicker`, we'll run the same command three times.

These changes dedupe the set of targets.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 18, 2026
@pullapprove pullapprove bot requested a review from josephperrott January 18, 2026 09:31
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 18, 2026
josephperrott
josephperrott approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 20, 2026
@crisbeto crisbeto merged commit 1f8b4b5 into angular:main Jan 20, 2026
29 of 31 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Jan 20, 2026

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jan 20, 2026
@crisbeto
build: dedupe targets in api golden script (#32669)
b619097 
In the past we had one API golden target per component, but now the target is per package. This means that if we run something like `approve-goldens material/button material/dialog material/datepicker`, we'll run the same command three times.

These changes dedupe the set of targets.

(cherry picked from commit 1f8b4b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @josephperrott