fix(multiple): incorrect paths in declaration files for aria #32673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
angular-robot
bot
added
the
area: build & ci
Fixes that the Aria package didn't enable the `ts-compat` and `linker` integration tests which in turn didn't catch some errors.
A few places in the `@angular/aria` package were producing invalid paths when compiled for npm. We didn't catch them, because the Aria package wasn't running the same integration tests as the rest of the repo. These changes fix the issues by using explicit type annotations. Fixes angular#32665.
crisbeto
force-pushed
the
32665/more-aria-builds
branch
from
4ee745a to
25f40e0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places in the
@angular/ariapackage were producing invalid paths when compiled for npm. We didn't catch them, because the Aria package wasn't running the same integration tests as the rest of the repo.These changes fix the issues by using explicit type annotations.
Fixes #32665.