feat: [Compiler] format generated code by header and line break #3233 #3244
+275
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavisha4193
changed the title
…tructs - Add wrap_line/wrap_lines methods to BaseGenerator for smart line breaking - Override wrap_line in Go generator to preserve function signatures and struct tags - Override wrap_line in Python generator to preserve assignments and conditionals - Modify Java generator to use string concatenation for long error messages - Fix ruff formatting issues (multi-line if statements, trailing whitespace) This fixes syntax errors in generated IDL code across Java, Go, and Python.
chaokunyang
reviewed
Jan 30, 2026
| PrimitiveKind.ANY: "None", | ||
| } | ||
|
|
||
| def wrap_line( |
Collaborator
There was a problem hiding this comment.
Does this func handle cpp macro registeration and Python indent right?
We don't have semantics ath this line level. Maybe it will be more safe If we add line breaker when generating code in each language.
chaokunyang
reviewed
Jan 30, 2026
| PrimitiveKind.ANY: "any", | ||
| } | ||
|
|
||
| def wrap_line( |
Collaborator
There was a problem hiding this comment.
I prefer break line in each language at semantic level when generating code. Otherwise it's every easy to add wrong line breaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
[Compiler] format generated code by header and line break
What does this PR do?
[Compiler] format generated code by header and line break
Related issues
Is there any related issue? If this PR closes them you say say fix/closes: