-
Notifications
You must be signed in to change notification settings - Fork 426
fix(ui): Improve structural CSS warning message format, warn for appearance usage on components #7628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Clearer title and explanation - Package manager agnostic install instructions - Use (code=structural_css_pin_clerk_ui) error code format Co-Authored-By: Claude Opus 4.5 <[email protected]>
Previously, the structural CSS warning only triggered when ClerkProvider
mounted. This adds checking when individual components mount with their
own appearance prop (e.g., <SignIn appearance={...} />).
- Add warnAboutComponentAppearance() for checking component-level appearance
- Add useWarnAboutCustomizationWithoutPinning hook called from AppearanceProvider
- Hook gracefully handles missing context (e.g., in tests)
- Only runs in development mode
Co-Authored-By: Claude Opus 4.5 <[email protected]>
🦋 Changeset detectedLatest commit: 9f7563c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughIntroduces a development-only structural CSS warning flow: adds hook 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
…owser.js - ui.browser.js: 34KB -> 34.5KB - ui.legacy.browser.js: 72KB -> 73KB Co-Authored-By: Claude Opus 4.5 <[email protected]>
Description
BEFORE
AFTER
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.