-
Notifications
You must be signed in to change notification settings - Fork 427
fix(shared): Remove billingEnabled gate from useStripeClerkLibs #7639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The SWR removal PR (#7568) inadvertently added a `billingEnabled` check to `useStripeClerkLibs` that wasn't present in the original SWR implementation. This caused Stripe elements to not load on the Billing screen because the query was gated by: - billing being enabled in environment settings - user being authenticated - clerk.loaded being true The original SWR implementation loaded the Stripe SDK unconditionally. This restores that behavior by removing the `useBillingHookEnabled` check from the hook.
🦋 Changeset detectedLatest commit: 3823115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe change removes the `useBillingHookEnabled` import and the `billingEnabled` gating flag from the `useStripeClerkLibs` hook. As a result, the Stripe clerk libs query is no longer conditionally blocked by the billing hook and can run unconditionally. No other logic, return types, or public export names were modified. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
Fixes Stripe elements not loading by removing the
billingEnabledgate fromuseStripeClerkLibsthat was inadvertently added during SWR removal.Root Cause
During the SWR removal (#7568), a
useBillingHookEnabled()check was added to gate the Stripe SDK loadingThe original SWR implementation loaded the Stripe SDK unconditionally without this gate.
Look at the request to stripe:
Test plan