Skip to content

Fix GPG verification with reformatted keys #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EhabY merged 2 commits into from
Jan 23, 2026
Merged

Fix GPG verification with reformatted keys #748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15c38a1
Fix GPG verification with reformatted keys
EhabY Jan 23, 2026
179d73a
Add rational comment
EhabY Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pgp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ export async function verifySignature(
message,
signature,
verificationKeys: publicKeys,
config: {
// Rational https://github.com/coder/vscode-coder/pull/748#issuecomment-3789538490
allowInsecureVerificationWithReformattedKeys: true,
},
});
for await (const _ of verificationResult.data) {
// The docs indicate this data must be consumed; it triggers the
Expand Down