Update tests bird watcher

[jagdish-15]

pull request

This would catch solutions like these:

    public int[] getLastWeek() {
        return birdsPerDay;
    }

    public void incrementTodaysCount() {
        for (int i = 1; i < birdsPerDay.length; i++) {
            birdsPerDay[i] = birdsPerDay[i] + 1;
        }
    }

Variants like this have appeared in student solutions and currently pass the tests, even though they don’t align with the exercise instructions

---

Reviewer Resources:

Track Policies

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[kahgoh]

This is going to invalidate solutions that return the array in getLastWeek, like this one.

If our objective is to just capture the incrementTodaysCount, I think we could just change itIncrementTodaysCount.

[jagdish-15]

I see what you’re getting at, but this solution is fundamentally incorrect:

    public int[] getLastWeek() {
        return birdsPerDay;
    }

This method returns the current week, not the previous week.
According to the exercise instructions: "For comparison purposes, you always keep a copy of last week's counts nearby, which were: 0, 2, 5, 3, 7, 8 and 4. "

If birdsPerDay were truly representing the previous week, then the last index of the array could not correspond to today. That alone makes this implementation inconsistent with the intended model.

These solutions were effectively getting a free pass because the test data happened to use the same values for both the current week and the “previous week” mentioned in the introduction. As a result, logically incorrect implementations still passed the tests.

Curious to hear your thoughts on this.

[kahgoh]

Ah, this is a clever way (using getCountForFirstDays). Just couple of minor comments for this one:

• We could simplify this by doing calculating the expected value directly, like we currently do in the other test for getCountForFirstDays (i.e. assertThat(birdWatcher.getCountForFirstDays(6)).isEqualTo(DAY1 + DAY2 + DAY3 + DAY4 + DAY5 + DAY6);).
• I think it can be confusing why we're asserting getCountForFirstDays in this test. I'd suggest moving to a separate test so that the test can be described in the @DisplayName and test name. For example:

public void itIncrementDoesNotChangeCountForOtherDays() {
  birdWatcher.incrementTodaysCount();
  assertThat(birdWatcher.getCountForFirstDays(6)).isEqualTo(DAY1 + DAY2 + DAY3 + DAY4 + DAY5 + DAY6);
}