-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: Extract grounding_metadata from Live API server_content #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VedantMadane
wants to merge
9
commits into
google:main
Choose a base branch
from
VedantMadane:fix/live-api-grounding-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
30af2f1
fix: Extract grounding_metadata from Live API server_content
VedantMadane 377a632
Merge branch 'main' into fix/live-api-grounding-metadata
VedantMadane b0bd310
Address Gemini Code Assist review feedback
VedantMadane 494141d
Merge branch 'main' into fix/live-api-grounding-metadata
VedantMadane 2fabdb4
fix: Apply autoformat to gemini_llm_connection.py
VedantMadane 8e9fee6
fix: Don't reset grounding_metadata after tool_call
VedantMadane dfe53f7
fix: Resolve HIGH priority grounding_metadata state management issues
VedantMadane 0cd44c8
test: Add test for interrupted signal preservation with pending text
VedantMadane 27f3391
Merge branch 'main' into fix/live-api-grounding-metadata
VedantMadane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line prematurely resets
last_grounding_metadata. The grounding metadata should persist for the entire duration of a turn and only be reset when the turn is complete, as is correctly handled in theturn_completeblock.Other parts of the code that flush buffered text (e.g., when handling
tool_callorinterruptedsignals) correctly preserve the metadata for the remainder of the turn. Resetting it here is inconsistent with that logic and could cause grounding information to be lost before the turn ends.To ensure consistent behavior, this line should be removed.