Nik/spaces #582
Merged
Nik/spaces #582
+211
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for distinguishing between PERSONAL and DAO space types in the hypergraph package. It introduces a type field to the PublicSpace schema and adds filtering capability by space type.
Changes:
- Added
typefield (either 'PERSONAL' or 'DAO') toPublicSpaceschema and query results - Refactored query construction from three static parameterized queries to dynamic query building based on filters
- Added
spaceTypefilter option toFindManyPublicFilterallowing filtering by space type, optionally combined with existing member/editor filters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.changeset/add-space-type.md |
Documents the new type field and spaceType filter in the changeset |
.claude/settings.local.json |
Adds additional allowed bash commands for development tooling |
packages/hypergraph/src/space/find-many-public.ts |
Adds type field to schema, implements dynamic query building with spaceType filter support |
packages/hypergraph/test/space/find-many-public.test.ts |
Updates tests to include type field and adds test case for DAO type parsing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.