-
Notifications
You must be signed in to change notification settings - Fork 237
Accessible Server List #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessible Server List #3606
Conversation
c7be8f1 to
3b74fe8
Compare
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll check it out once I have access to macOS
|
I haven't tested on Windows, but it should work both Windows and MacOS. |
3b74fe8 to
f902bc2
Compare
Reports correct number of musicians.
|
@ann0see Could you confirm if it reports the information in the right order and the correct number of musicians? |
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think now it works as expected. If a new user connects, the server name is correctly announced and a number is up to date. Also the order is now correct.
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I've tested it on Windows, I'll report back. Otherwise, I think it's fine. Thank you very much! It's by far the cleanest approach.
|
Once this is merged, I'm going to kill my old build because all my accessibility fixes are merged. |
|
(Windows woks with the native tree view) |
Make the server list accessible by making the screen reader to announce relevant information when a server or a client is selected.
@pljones @ann0see