Fix e2e test, which was broken due to helm4 upgrade #759
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
wallrj-cyberark
approved these changes
Jan 22, 2026
Member
There was a problem hiding this comment.
Thanks @inteon
I tested it locally and the fix seems to work well
richard@localhost:~/projects/jetstack/jetstack-secure$ make helm-plugins
>>> Installing helm-diff plugin
Error: plugin source does not support verification. Use --verify=false to skip verification
make: *** [make/02_mod.mk:72: helm-plugins] Error 1
richard@localhost:~/projects/jetstack/jetstack-secure$ gh pr checkout 759
branch 'helm4_e2e_fix' set up to track 'origin/helm4_e2e_fix'.
Switched to a new branch 'helm4_e2e_fix'
richard@localhost:~/projects/jetstack/jetstack-secure$ make helm-plugins
>>> Installing helm-diff plugin
WARNING: Skipping plugin signature verification
Downloading https://github.com/databus23/helm-diff/releases/download/v3.9.8/helm-diff-linux-amd64.tgz
Preparing to install into /home/richard/.local/share/helm/plugins/helm-diff
Installed plugin: diff
Merge when the E2E tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Helm 4, we have to pass the --verify=false flag (see https://github.com/databus23/helm-diff/blob/0a397b436a2a676c3cce98a9b3bb21a592e09859/README.md?plain=1#L29).
This causes the e2e test to fail (eg. https://github.com/jetstack/jetstack-secure/actions/runs/21257026671/job/61174350691?pr=758).