-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added sport-shoe icon
#3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
| "contributors": [ | ||
| "Youya-ui" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the sport-shoe icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "jogging", | |
| "sneakers", | |
| "gear", | |
| "outdoor", |
Added or changed iconsIcons as codeWorks for: const SportShoeIcon = createLucideIcon('SportShoe', [
["path",{"d":"M19 18h3"}],
["path",{"d":"M20 6.44c.696.534 1.226.957 1.414 1.146a2 2 0 0 1 0 2.828L8.5 22zA357 357 0 0 0 14 2c0 2 .622 4-1.028 5.201C11.875 8 9 8 9 8s-.911 6.249-2.9 8.737c0 0-.995 1.263-2.1 1.263a2 2 0 0 0 0 4h16"}]
]) |
karsa-mistmere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Youya-ui,
How exactly is this different from #3846?
Other than that, I'm afraid this design is not yet fully compliant with our design guidelines, I guess the most severe issues would be:
- Some sharp corners require additional rounding
- The sole doesn't have the necessary 2px gap between its confining paths
- The cubic curve path segments could do with better curvature, and we should probably consider converting some of them to grid-aligned arcs
|
Thanks for the feedback @karsa-mistmere ! About #3846: It was indeed the same icon. I closed it and re-submitted via the Studio because I initially thought something was wrong with my original PR (workflows not running, branch naming differing from other PRs, etc.). Sorry for the confusion — this PR is meant to replace that one, not duplicate it. About your review comments:
Please let me know if there are any specific areas you'd like me to refine further.
|

What is the purpose of this pull request?
Description
Added new
sport-shoeicon representing athletic footwear in motion.Icon use case
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting