-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added tag-plus and tag-x icons
#3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
| "ericfennis", | ||
| "karsa-mistmere" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the tag-plus icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "tag", | |
| "plus", | |
| "tagging", | |
| "category", | |
| "marker", | |
| "sign", | |
| "symbol", | |
| "tagging", |
| "ericfennis", | ||
| "karsa-mistmere" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the tag-x icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "tag", | |
| "price", | |
| "category", | |
| "tagging", | |
| "tagged", | |
| "classification", | |
| "identifier", | |
| "marker", |
Added or changed iconsIcons as codeWorks for: const TagPlusIcon = createLucideIcon('TagPlus', [
["path",{"d":"M16 13h6"}],
["path",{"d":"m16.5 6.5-3.914-3.914A2 2 0 0 0 11.172 2H4a2 2 0 0 0-2 2v7.172a2 2 0 0 0 .586 1.414l8.704 8.704a2.426 2.426 0 0 0 3.42 0l1.79-1.79"}],
["path",{"d":"M19 10v6"}],
["circle",{"cx":"7.5","cy":"7.5","r":".5","fill":"currentColor"}]
])
const TagXIcon = createLucideIcon('TagX', [
["path",{"d":"m16.5 6.5-3.914-3.914A2 2 0 0 0 11.172 2H4a2 2 0 0 0-2 2v7.172a2 2 0 0 0 .586 1.414l8.704 8.704a2.43 2.43 0 0 0 3.42 0l1.79-1.79"}],
["path",{"d":"m17 10.5 5 5"}],
["path",{"d":"m22 10.5-5 5"}],
["circle",{"cx":"7.5","cy":"7.5","r":".5","fill":"currentColor"}]
]) |
|
Hey @adam-kov, Overall really nice work on this, I have but one qualm: as per #3875 the cross should be our 5by5 variant, positioned in the same way as |
Description
Added new
tag-plusandtag-xicons.Icon use case
plus,x,edit, etc. variations.tagicon. Users can add products, so I'd rather use thetag-plusicon in the "New product" button instead of the genericplusone.tag-xicon for deleting a product.Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
tag,plus,xNaming
icons/[iconName].json.Design
Before Submitting