-
Notifications
You must be signed in to change notification settings - Fork 7
Add code review agents #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pontemonti
wants to merge
2
commits into
main
Choose a base branch
from
users/johanb/CodeReviewAgents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,726
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created design documents for the following observability extensions: - Agent Framework - LangChain - OpenAI - Semantic Kernel - Created design documents for the following tooling extensions: - Agent Framework - Azure AI Foundry - OpenAI - Semantic Kernel - Added a comprehensive design document for the core tooling package, detailing architecture, key components, and usage.
- Introduced `code-reviewer` agent for expert code reviews on Python implementations using Microsoft 365 Agents SDK. - Added `pr-comment-resolver` agent to systematically address code review comments on pull requests. - Implemented `test-coverage-reviewer` agent to verify test coverage and quality for code changes. - Updated `.gitignore` to include local settings and code review directories. - Created `CLAUDE.md` for project guidance, including setup, development commands, architecture, code standards, and CI/CD processes.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds comprehensive design documentation and Claude Code agent configurations to support code review workflows.
Changes:
- Adds main architecture and design documentation (
docs/design.md,CLAUDE.md) - Adds package-specific design documents for all 13 packages in the monorepo
- Creates Claude Code agent configurations for automated code review workflows (architecture-reviewer, code-reviewer, test-coverage-reviewer, code-review-manager, pr-comment-resolver)
- Updates
.gitignoreto allow.claude/agents/directory while ignoring local settings and code review outputs
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
docs/design.md |
Main architecture and design document covering all packages, patterns, data flows, and development workflows |
CLAUDE.md |
Developer guidance for Claude Code with setup commands, architecture overview, and code standards |
libraries/microsoft-agents-a365-tooling/docs/design.md |
Design document for the tooling package covering MCP server configuration and discovery |
libraries/microsoft-agents-a365-tooling-extensions-semantickernel/docs/design.md |
Design document for Semantic Kernel tooling extensions |
libraries/microsoft-agents-a365-tooling-extensions-openai/docs/design.md |
Design document for OpenAI tooling extensions |
libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/docs/design.md |
Design document for Azure AI Foundry tooling extensions |
libraries/microsoft-agents-a365-tooling-extensions-agentframework/docs/design.md |
Design document for Agent Framework tooling extensions |
libraries/microsoft-agents-a365-runtime/docs/design.md |
Design document for runtime package covering utilities, API discovery, and result patterns |
libraries/microsoft-agents-a365-observability-extensions-semantickernel/docs/design.md |
Design document for Semantic Kernel observability extensions |
libraries/microsoft-agents-a365-observability-extensions-openai/docs/design.md |
Design document for OpenAI observability extensions |
libraries/microsoft-agents-a365-observability-extensions-langchain/docs/design.md |
Design document for LangChain observability extensions |
libraries/microsoft-agents-a365-observability-extensions-agentframework/docs/design.md |
Design document for Agent Framework observability extensions |
libraries/microsoft-agents-a365-observability-core/docs/design.md |
Design document for observability core package covering OpenTelemetry-based tracing |
libraries/microsoft-agents-a365-notifications/docs/design.md |
Design document for notifications package covering notification handling and routing |
.claude/agents/test-coverage-reviewer.md |
Agent configuration for reviewing test coverage and quality |
.claude/agents/pr-comment-resolver.md |
Agent configuration for systematically addressing code review comments |
.claude/agents/code-reviewer.md |
Agent configuration for Python code review focusing on Microsoft 365 SDK usage |
.claude/agents/code-review-manager.md |
Agent configuration for coordinating multi-dimensional code reviews |
.claude/agents/architecture-reviewer.md |
Agent configuration for reviewing architectural alignment with design docs |
.gitignore |
Updated to allow .claude/agents/ directory and ignore .codereviews/ and local settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.