feat: show update available notif for modrinth app in linux #5181
+121
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prospector
requested changes
Jan 23, 2026
| @restart="installUpdate" | ||
| @download="downloadAvailableUpdate" | ||
| /> | ||
| <UpdateAvailableToast v-else-if="os === 'Linux' && !isDevEnvironment" /> |
Member
There was a problem hiding this comment.
there's a specific env var for when updates are disabled and managed by the package manager, should check that instead of just for the OS
Prospector
requested changes
Jan 23, 2026
| body: { | ||
| id: 'app.update-toast.body.linux', | ||
| defaultMessage: | ||
| 'Modrinth App v{version} is ready to install! Restart the app to apply the update once it has been installed by your system.', |
Member
There was a problem hiding this comment.
i'd suggest the copy:
"Modrinth App v{version} is available. Use your package manager to update for the latest features and fixes!"
and I'd remove the Restart button because it doesn't really serve a purpose. They would likely need to close the app to update anyway I'd imagine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.