Skip to content

src: use C++ nullptr in sqlite #61416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tniessen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use C++ nullptr in sqlite #61416

tniessen wants to merge 1 commit into from
+2 −2

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jan 17, 2026

Refs: #61407

@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 17, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (2679b62) to head (6b2ded3).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61416      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.01%     
==========================================
  Files         704      704              
  Lines      208796   208883      +87     
  Branches    40312    40333      +21     
==========================================
+ Hits       184828   184898      +70     
- Misses      15955    15973      +18     
+ Partials     8013     8012       -1
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.17% <100.00%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 18, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70865/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70866/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

+1 more reviewer

@louwers louwers louwers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @nodejs-github-bot @louwers @cjihrig @Renegade334