test_runner: print coverage and diagnostic info with dot reporter #61423
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
When using the dot reporter with coverage enabled, coverage threshold failures and coverage reports were not printed, only an exit code was returned. This made it impossible to know why the test run failed. This change adds handling for test:diagnostic and test:coverage events to the dot reporter, matching the behavior of the spec reporter. Fixes: nodejs#60884
mag123c
force-pushed
the
fix-dot-reporter-coverage
branch
from
83840c7 to
313a274
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61423 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01%
==========================================
Files 704 704
Lines 208883 208906 +23
Branches 40333 40336 +3
==========================================
+ Hits 184926 184936 +10
- Misses 15934 15947 +13
Partials 8023 8023
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds coverage and diagnostic output to the dot reporter in test_runner.
Currently, when using dot reporter with coverage enabled, if coverage threshold fails, the program exits with code 1 but prints nothing about why it failed. Users have no way to know what went wrong. The spec reporter already handles this correctly.
Changes:
test:diagnosticevents (coverage threshold failure messages)test:coverageevents (coverage report table)Now dot reporter behaves consistently with spec reporter for coverage output.
Fixes: #60884