-
Notifications
You must be signed in to change notification settings - Fork 71
fix: exclude resource/download ssoInterceptor #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded "/material-center/api/resource/download/*" to the SSO interceptor exclusion list in LoginConfig alongside an existing chat completions exclusion; no signature or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@base/src/main/java/com/tinyengine/it/login/config/LoginConfig.java`:
- Around line 45-46: LoginConfig currently whitelists
"/material-center/api/resource/download/*", making downloads publicly
accessible; confirm whether that is intentional. If it is intentional, document
the decision by adding a clear comment and/or configuration flag (e.g.,
allowPublicResourceDownloads) near the whitelist in LoginConfig and add a
unit/integration test that verifies public access; if it is NOT intentional,
remove "/material-center/api/resource/download/*" from the whitelist (or move it
behind SSO enforcement) so the download endpoints require authentication.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.