[FEATURE] Selection provider #539
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Bernal <[email protected]>
Signed-off-by: Gabriel Bernal <[email protected]>
| { label: 'Column Settings', content: TableColumnsEditor }, | ||
| { label: 'Cell Settings', content: TableCellsEditor }, | ||
| { label: 'Transforms', content: TableTransformsEditor }, | ||
| { label: 'Selections', content: TableSelectionsEditor }, |
Contributor
There was a problem hiding this comment.
I find it a bit overkill to have a whole new tab in the panel settings that allows to tune a single attribute in the end. Could we make it a sub-section of the General Settings instead?
Member
There was a problem hiding this comment.
Yeah, I agree. I think it could be put in General settings or directly in Item Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: perses/perses#3788
Requires: perses/shared#40
Screenshots
// TODO
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes