-
Notifications
You must be signed in to change notification settings - Fork 41
[FEATURE] Table: migrate column datalink overrides #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: PeterYurkovich <[email protected]>
e83250e to
71ac72e
Compare
|
@shahrokni I was trying out the data links feature you added and noticed that there wasn't any migrations on dashboards happening yet. Mind reviewing if you have the chance? |
AntoineThebaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration logic of the Table panel is not easy to deal with, well done!
|
This comment is beyond this review, and 99% is wrong. However, I could not resist to put a comment and ask the following question. In the description, you have mentioned that
I would like to mention that in Perses the entire table can be linked. So, the question would be couldn't the default data link be used for the table link? Does that make sense? |
|
| I would like to mention that in Perses the entire table can be linked. So, the question would be couldn't the default data link be used for the table link? Does that make sense? Links can be located at Since cuelang doesn't allow for overriding parent properties I think it would probably be better to set the perses |
Signed-off-by: PeterYurkovich <[email protected]>
6827a4a to
2de718c
Compare
|
True, I'm going to work on checking the general panel link migration as Panel links are already supported: perses/perses#1916 |
Signed-off-by: PeterYurkovich
Description
This PR looks to enable migrating column specific data links from overrides. The perses column data links only currently supports a single link, so the last link is taken from the list of links that are added in the overrides. This PR does not take into account default data links set for the whole table.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.