Skip to content

Conversation

@PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Jan 28, 2026

Signed-off-by: PeterYurkovich

Description

This PR looks to enable migrating column specific data links from overrides. The perses column data links only currently supports a single link, so the last link is taken from the list of links that are added in the overrides. This PR does not take into account default data links set for the whole table.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@PeterYurkovich
Copy link
Contributor Author

@shahrokni I was trying out the data links feature you added and noticed that there wasn't any migrations on dashboards happening yet. Mind reviewing if you have the chance?

Copy link
Contributor

@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration logic of the Table panel is not easy to deal with, well done!

@shahrokni
Copy link
Contributor

shahrokni commented Jan 29, 2026

This comment is beyond this review, and 99% is wrong. However, I could not resist to put a comment and ask the following question.

In the description, you have mentioned that

This PR does not take into account default data links set for the whole table.

I would like to mention that in Perses the entire table can be linked. So, the question would be couldn't the default data link be used for the table link? Does that make sense?
@AntoineThebaud
@PeterYurkovich

@PeterYurkovich
Copy link
Contributor Author

| I would like to mention that in Perses the entire table can be linked. So, the question would be couldn't the default data link be used for the table link? Does that make sense?

Links can be located at .links[], .fieldConfig.defaults.links[] and .fieldConfig.overrides[] where .links[] is the panel links and the .fieldConfig ones are related to the text within the table.

Since cuelang doesn't allow for overriding parent properties I think it would probably be better to set the perses #Panel.spec.links (link) generically by checking the .links[] value, for any panel type, but I am unfamiliar with cuelang and may be off base here with what is possible

@jgbernalp
Copy link
Contributor

True, I'm going to work on checking the general panel link migration as Panel links are already supported: perses/perses#1916

@jgbernalp jgbernalp added this pull request to the merge queue Jan 29, 2026
Merged via the queue into perses:main with commit 3932acf Jan 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants