Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Lib/email/_header_value_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ def make_quoted_pairs(value):
return str(value).replace('\\', '\\\\').replace('"', '\\"')


def make_parenthesis_pairs(value):
"""Escape parenthesis and backslash for use within a comment."""
return str(value).replace('\\', '\\\\') \
.replace('(', '\\(').replace(')', '\\)')


def quote_string(value):
escaped = make_quoted_pairs(value)
return f'"{escaped}"'
Expand Down Expand Up @@ -943,7 +949,7 @@ def value(self):
return ' '

def startswith_fws(self):
return True
return self and self[0] in WSP


class ValueTerminal(Terminal):
Expand Down Expand Up @@ -2963,6 +2969,13 @@ def _refold_parse_tree(parse_tree, *, policy):
[ValueTerminal(make_quoted_pairs(p), 'ptext')
for p in newparts] +
[ValueTerminal('"', 'ptext')])
if part.token_type == 'comment':
newparts = (
[ValueTerminal('(', 'ptext')] +
[ValueTerminal(make_parenthesis_pairs(p), 'ptext')
if p.token_type == 'ptext' else p
for p in newparts] +
[ValueTerminal(')', 'ptext')])
if not part.as_ew_allowed:
wrap_as_ew_blocked += 1
newparts.append(end_ew_not_allowed)
Expand Down
23 changes: 23 additions & 0 deletions Lib/test/test_email/test__header_value_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -3294,6 +3294,29 @@ def test_address_list_with_specials_in_long_quoted_string(self):
with self.subTest(to=to):
self._test(parser.get_address_list(to)[0], folded, policy=policy)

def test_address_list_with_long_unwrapable_comment(self):
policy = self.policy.clone(max_line_length=40)
cases = [
# (to, folded)
('(loremipsumdolorsitametconsecteturadipi)<[email protected]>',
'(loremipsumdolorsitametconsecteturadipi)<[email protected]>\n'),
('<[email protected]>(loremipsumdolorsitametconsecteturadipi)',
'<[email protected]>(loremipsumdolorsitametconsecteturadipi)\n'),
('(loremipsum dolorsitametconsecteturadipi)<[email protected]>',
'(loremipsum dolorsitametconsecteturadipi)<[email protected]>\n'),
('<[email protected]>(loremipsum dolorsitametconsecteturadipi)',
'<[email protected]>(loremipsum\n dolorsitametconsecteturadipi)\n'),
('(Escaped \\( \\) chars \\\\ in comments stay escaped)<[email protected]>',
'(Escaped \\( \\) chars \\\\ in comments stay\n escaped)<[email protected]>\n'),
('((loremipsum)(loremipsum)(loremipsum)(loremipsum))<[email protected]>',
'((loremipsum)(loremipsum)(loremipsum)(loremipsum))<[email protected]>\n'),
('((loremipsum)(loremipsum)(loremipsum) (loremipsum))<[email protected]>',
'((loremipsum)(loremipsum)(loremipsum)\n (loremipsum))<[email protected]>\n'),
]
for (to, folded) in cases:
with self.subTest(to=to):
self._test(parser.get_address_list(to)[0], folded, policy=policy)

# XXX Need tests with comments on various sides of a unicode token,
# and with unicode tokens in the comments. Spaces inside the quotes
# currently don't do the right thing.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fixed a bug in the folding of comments when flattening an email message
using a modern email policy. Comments consisting of a very long sequence of
non-foldable characters could trigger a forced line wrap that omitted the
required leading space on the continuation line, causing the remainder of
the comment to be interpreted as a new header field. This enabled header
injection with carefully crafted inputs.
Loading