gh-89900: Add option to preserve existing handlers for assertLogs #143970
+53
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89900
Description
The Problem
The Fix
Added optional keep_handlers param in assertLogs inside
Lib/unittest/case.pyto optionally preserve existing handlers for assertLogs, preventing the situation described above where the same exact test must be run twiceSince keep_handlers is
Falseby default, this change is backwards-compatible.Tests
Added new test cases in
Lib/test/test_unittestto ensure keep_handlers=True preserves existing handlers.Validation
Ran
./python.exe -m test test_unittestand passed all 1093 tests📚 Documentation preview 📚: https://cpython-previews--143970.org.readthedocs.build/