[mypyc] feat: support constant folding in convert_format_expr_to_str [1/1]
#19970
+35
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Oct 2, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Are there existing run tests that cover this? If not, it would be good to add some. Maybe also add a simple irbuild test or two.
hauntsaninja
approved these changes
Jan 18, 2026
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good! Just need to fix up the test case :-)
Contributor
Author
|
Hmm. not sure what happened there. I didn't do anything in that file. |
Collaborator
|
That was a merge race from me merging an old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for constant folding inside of
convert_format_expr_to_str