Skip to content

feat: migrate sidebar to Base UI #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rohanchkrabrty wants to merge 1 commit into
base: base-scrollarea
Choose a base branch
from
Open

feat: migrate sidebar to Base UI #573

rohanchkrabrty wants to merge 1 commit into from

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Jan 30, 2026

Description

Breaking Changes

  • Data attributes changed: data-state="expanded" → data-open, data-state="collapsed" → data-closed
  • Data attribute format: Boolean data attributes now use presence-based format (e.g., data-collapse-disabled instead of data-collapse-disabled="true")

Changes

  • Removed @radix-ui/react-collapsible dependency - component now uses plain useState for state management
  • Component no longer extends Radix's Collapsible.Root props, now extends ComponentPropsWithoutRef<'aside'>
  • Added explicit defaultOpen = true default value
  • Simplified internal state handling with direct useState instead of Collapsible wrapper

Docs & Tests

  • Updated CSS selectors to use new data attributes ([data-open], [data-closed], [data-collapse-disabled])
  • Updated test assertions for data-closed attribute instead of data-state="collapsed"
  • Updated onOpenChange callback signature remains (open: boolean) => void

@rohanchkrabrty rohanchkrabrty self-assigned this Jan 30, 2026
@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Jan 30, 2026 9:52am

@rohanchkrabrty rohanchkrabrty changed the base branch from main to base-scrollarea January 30, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsbh rsbh Awaiting requested review from rsbh

@paanSinghCoder paanSinghCoder Awaiting requested review from paanSinghCoder

Assignees

@rohanchkrabrty rohanchkrabrty

Labels

Do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohanchkrabrty