Use .mjs/.cjs extension for runtime files #8207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
runtime-cjs-mjs
branch
from
9b76c03 to
b052690
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ReScript runtime files to use explicit module system file extensions (.mjs for ES modules and .cjs for CommonJS) instead of the generic .js extension, eliminating the need for a package.json override in the CommonJS directory.
Changes:
- Updated all import/require statements in runtime files to use the correct file extensions
- Modified compiler logic to generate the appropriate file extensions for runtime modules
- Removed runtime package specs configuration that was previously needed
Reviewed changes
Copilot reviewed 116 out of 587 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/@rescript/runtime/lib/js/*.cjs |
Updated require statements to use .cjs extension instead of .js |
packages/@rescript/runtime/lib/es6/*.mjs |
Updated import statements to use .mjs extension instead of .js |
compiler/core/js_packages_info.ml |
Removed runtime package specs configuration and related comments |
compiler/core/js_name_of_module_id.ml |
Added logic to determine runtime file extensions based on module system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nojaf
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the JS files in
packages/@rescript/runtime/lib/es6packages/@rescript/runtime/lib/jsall have the extension
.jsand not the specific extension for their module system.Therefore,
packages/@rescript/runtime/lib/js/package.jsonis needed to override the module system for the commonjs files.This PR instead adds the specific file extension for each module system:
packages/@rescript/runtime/lib/es6/*.mjspackages/@rescript/runtime/lib/js/*.cjsThis makes things clearer and allows us to get rid of the override.