Skip to content

Convert to String earlier in generate-windows-versions.rb #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 1 commit into from
Jan 18, 2026
+2 −2
Merged

Convert to String earlier in generate-windows-versions.rb #862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generate-windows-versions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# Validate all the URLs in the versions json
def validate(versions, allowed_urls_regexps)
versions.values.flat_map(&:values).each do |url|
if allowed_urls_regexps.none? { |regexp| regexp.match? url.to_s }
if allowed_urls_regexps.none? { |regexp| regexp.match? url }
raise SecurityError, "Unexpected URL: #{url}"
end
end
Expand Down Expand Up @@ -112,7 +112,7 @@ def validate(versions, allowed_urls_regexps)
raise "#{toolchain.empty? ? 'no' : 'multiple'} toolchains found for #{raw_version} #{raw_arch}: #{toolchain}"
end

archs[raw_arch] = URI.join(base_url, toolchain.first[:href])
archs[raw_arch] = URI.join(base_url, toolchain.first[:href]).to_s
end
end

Expand Down