Skip to content

Conversation

@lxsmnsyc
Copy link
Member

This PR moves the current server function compiler from tanstack to dismantle.

Warning

Currently there's only one regression: since dismantle doesn't do an in-place replacement of the server function, it's not able to read local dependencies/side-effects except for module imports.
Once dismantle is incorporated, we will require users to either move top-level variables/functions inside a server function or move those into separate module so dismantle can handle it properly.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2026

⚠️ No Changeset found

Latest commit: 9eab97c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 9eab97c
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/696ce2549d8ba70008c089e5
😎 Deploy Preview https://deploy-preview-2052--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 18, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2052
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2052

commit: 9eab97c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants