Skip to content

Conversation

@CyberT17
Copy link
Contributor

@CyberT17 CyberT17 commented Jan 21, 2026

fix(backend): Fixed parsing of ALWAYS_INDEX_FILE_PATTERNS by surrounding it with double quotes
fixes #772

Summary by CodeRabbit

  • Bug Fixes

    • Fixed parsing of file patterns containing special characters or spaces so indexing treats them correctly.
  • Documentation

    • Updated release notes to document the parsing correction for the ALWAYS_INDEX_FILE_PATTERNS environment variable.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

Each -large_file argument passed to zoekt-git-index is now wrapped in double quotes to prevent shell glob expansion of file pattern values (e.g., **/*.go) before the command runs.

Changes

Cohort / File(s) Summary
Shell expansion fix
packages/backend/src/zoekt.ts
Wrap -large_file pattern arguments in double quotes when constructing the zoekt-git-index command to stop the shell from expanding glob patterns provided via environment variables (e.g., ALWAYS_INDEX_FILE_PATTERNS).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing parsing of ALWAYS_INDEX_FILE_PATTERNS by wrapping patterns in quotes to prevent shell expansion.
Linked Issues check ✅ Passed The PR successfully implements the fix for issue #772 by wrapping ALWAYS_INDEX_FILE_PATTERNS patterns in quotes, preventing shell glob expansion and allowing patterns to be passed intact to zoekt-git-index.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the ALWAYS_INDEX_FILE_PATTERNS parsing issue: the zoekt.ts modification implements the fix, and the CHANGELOG.md entry documents it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msukkari
Copy link
Contributor

Hey @CyberT17 thanks for the fix. Please add a changelog and this should be good to go

@msukkari msukkari merged commit 6c39ff0 into sourcebot-dev:main Jan 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] ALWAYS_INDEX_FILE_PATTERNS env var not being honored due to shell expansion

2 participants