Skip to content

Conversation

@olivierauverlot
Copy link
Contributor

Here’s a proposal for a page to catalog the projects completed with SQLPage. Projects can be filtered using tags.

Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ! This looks great ! I left my comments below

'no-store, no-cache, must-revalidate, max-age=0' AS "Cache-Control",
'no-cache' AS "pragma",
'0' AS "expires",
'<https://sql-page.com/safety>; rel="canonical"' AS "Link";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why safety ?

Comment on lines +24 to +42
SELECT
'stories' AS component,
$filter AS filter,
id,
title,
publication_date,
tags,
CASE
WHEN LENGTH(contents_md) > CAST($EXT_MAX_LENGTH AS INTEGER) THEN SUBSTR(contents_md, 1, CAST($TEXT_MAX_LENGTH AS INTEGER)) || '...'
ELSE contents_md
END as truncated_contents
FROM stories
WHERE
$id IS NULL
AND ($filter IS NULL OR EXISTS (SELECT 1 FROM json_each(tags) WHERE value LIKE $filter COLLATE NOCASE))
ORDER BY publication_date DESC;

SELECT
'story' AS component,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a single component with top level and row level props instead of two components ?

{"link": "/blog.sql", "title": "Blog", "icon": "book"},
{"link": "//github.com/sqlpage/SQLPage/issues", "title": "Report a bug", "icon": "bug"},
{"link": "//github.com/sqlpage/SQLPage/discussions", "title": "Discussions", "icon": "message"},
{"link": "/stories.sql", "title": "Stories", "icon": "user-screen"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"link": "/stories.sql", "title": "Stories", "icon": "user-screen"},
{"link": "/stories", "title": "Stories", "icon": "user-screen"},

Comment on lines +17 to +18
'This is an SQLPage based system I''ve developed for the organisation I work for to collate information on species within our area, running on FreeBSD and MariaDB. Collating the information is still a work in progress, but there''s a complete example data sheet at https://glincsson.glnp.org.uk/view?taxon_list_item_key=NBNORG0000018213 which pulls in all the various elements of information and a complete group listing at https://glincsson.glnp.org.uk/taxon_group?taxon_group=60 showing various colour coding and indicators.',
'SQLPage has made it trivial to implement this and allowed us to easily add in new aspects based on feedback from others. Most of it is stock SQLPage, but there are a couple of simple modified/custom components, with some custom javascript to allow saving png images of the maps. Its something we''ve long been wanted to do and have attempted in various guises over the years but using SQLPage is the first time we''ve been able to achieve exactly what we wanted (and more). And it''s been fun!',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the stories should either be in the third person, or be clearly signed by their author

publication_date TEXT NOT NULL,
contents_md TEXT NOT NULL,
optional_contents_md TEXT,
image TEXT,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a way to include more than one image ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants