Skip to content

Conversation

@sksamuel
Copy link

Kotest 6 was a major release with some small breaking changes to the API.
This PR updates the code and examples to reflect the changes.

@nedtwigg
Copy link
Member

Thanks very much for this implementation! Looks like you need to run ./gradlew spotlessApply and then push again. Assuming CI passes I'll be happy to merge and release.

I can update the changelogs myself, but I need an update to this file

The AbstractProjectConfig stuff changed in Kotest 6, and those docs need to reflect that.

@sksamuel
Copy link
Author

Spotless applied and docs updated. Let me know if you need further changes!

@sksamuel
Copy link
Author

I must be missing something locally as it has been green locally each time. Hopefully this last commit has it fixed on CI too.

@nedtwigg
Copy link
Member

fwiw:

- run: ./gradlew build --no-configuration-cache

The build can be a bit finnicky, tests that run tests seem to hit edge cases in Gradle.

@sksamuel
Copy link
Author

Gotcha, no big deal if you don't mind hitting approve each time to run the tests :)

@sksamuel
Copy link
Author

I got it to fail locally now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants